On Wed, Jul 19, 2023 at 01:26:06PM +0200, Arnd Bergmann wrote: > Adding __maybe_unused to both mxc_gpio_runtime_resume and > mxc_gpio_runtime_suspend would avoid the warning, and that is > what we used to do in the past before we had the new macros, > including for the mxc_gpio_noirq_suspend/mxc_gpio_noirq_resume > functions in this driver. > > Since I'm moving the driver to the new method, it's best to > do it for both pairs of PM functions at the same time, so > the __maybe_unused annotation becomes redundant. Ah, sorry. I misread the patch. regards, dan carpenter