Re: [libgpiod][PATCH v2 0/4] bindings: rust: clippy: fix warnings

[Kent Gibson <warthog618@xxxxxxxxx>]

On Fri, Jun 30, 2023 at 01:18:43PM +0200, Erik Schilling wrote:
> This follows up on my promise on Kent's series [1] to look into whether
> these casts are needed or not. Most are not, a few are false-positives.
> 
> I also explored some shunit2 based test-script to automate the testing,
> but that became ugly with linking issue and needs me to revisit it
> another time. So this only sends the clippy fixes for now.
> 
> Tested the build (lib + examples + test) and clippy report on:
> - Fedora 38 x86_64
> - Fedora 38 aarch64
> - Debian 12 armv7hf
> 
> Test execution (cargo test) was tested on:
> - Fedora 38 x86_64
> - Fedora 38 aarch64
> 
> Could not execute tests on armv7hf due to lack of suitable test
> environment.
> 
> [1] https://lore.kernel.org/r/20230612154055.56556-1-warthog618@xxxxxxxxx
> 
> To: Linux-GPIO <linux-gpio@xxxxxxxxxxxxxxx>
> Cc: Kent Gibson <warthog618@xxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> 

Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>

for the series.

> Signed-off-by: Erik Schilling <erik.schilling@xxxxxxxxxx>

Not sure you need to sign-off the cover letter.
e.g. `git format-patch --cover-letter -s` only signs off the patches,
not the cover letter.
Not that it matters - just for future reference.

Good to see the end all those clippy warnings.

Cheers,
Kent.

> ---
> Changes in v2:
> - Changed cover letter title to active language
> - Improved commit messages (hopefully)
> - Elaborated what was built and tested
> - Resent with hacked b4 for proper [libgpiod] tag
> - Link to v1: https://lore.kernel.org/r/20230629-clippy-v1-0-9ff088713c54@xxxxxxxxxx
> 
> ---
> Erik Schilling (4):
>       bindings: rust: clippy: drop unnecessary casts
>       bindings: rust: clippy: silence false-positives on casts
>       bindings: rust: clippy: drop unneeded conversions
>       bindings: rust: clippy: silence false-positive on iterator
> 
>  bindings/rust/gpiosim-sys/src/lib.rs         | 2 +-
>  bindings/rust/gpiosim-sys/src/sim.rs         | 4 ++--
>  bindings/rust/libgpiod/src/chip.rs           | 2 +-
>  bindings/rust/libgpiod/src/edge_event.rs     | 2 +-
>  bindings/rust/libgpiod/src/event_buffer.rs   | 7 +++++--
>  bindings/rust/libgpiod/src/info_event.rs     | 2 +-
>  bindings/rust/libgpiod/src/lib.rs            | 2 +-
>  bindings/rust/libgpiod/src/line_config.rs    | 4 ++--
>  bindings/rust/libgpiod/src/line_info.rs      | 3 +++
>  bindings/rust/libgpiod/src/line_request.rs   | 8 ++++----
>  bindings/rust/libgpiod/src/line_settings.rs  | 5 ++++-
>  bindings/rust/libgpiod/src/request_config.rs | 2 +-
>  bindings/rust/libgpiod/tests/chip.rs         | 2 +-
>  13 files changed, 27 insertions(+), 18 deletions(-)
> ---
> base-commit: 4510231c95a087f58a155cf74164e403e1e0584f
> change-id: 20230629-clippy-890c541c6d09
> 
> Best regards,
> -- 
> Erik Schilling <erik.schilling@xxxxxxxxxx>
>