Re: [libgpiod][PATCH] bindings: rust: fix clippy lint warnings

["Erik Schilling" <erik.schilling@xxxxxxxxxx>]

On Mon Jun 19, 2023 at 10:50 AM CEST, Viresh Kumar wrote:
> I missed these earlier, thanks for cc'ing me now Kent.
>
> On 19-06-23, 10:13, Erik Schilling wrote:
> > On Mon Jun 19, 2023 at 9:57 AM CEST, Kent Gibson wrote:
> > > My reasoning was simply that building the bindings as you suggested
> > > resulted in lint warnings, which is noisy and iritating when trying to
> > > lint my own code.
> > 
> > I fully agree that we should fix them! I was just confused about the
> > explanation.
> > 
> > > But I'm just the messenger.  Your question would be better directed at
> > > Viresh - it is his code so he should be able to tell you why the casts
> > > are there.
> > > IIRC we needed the casts historically, though I don't recall the rust
> > > version we were using at the time.
> > > If we've moved beyond that then I have no problem with the casts being
> > > removedi, in fact in my initial comment I lamented the fact they were
> > > necessary.
>
> I don't remember the versions used at that time, but here [1] are few
> of the auto-generated FFI bindings that I used to keep in my series
> then, in case these can help.
>
> IIRC, some of these were required for 32 bit builds. Don't remember
> the exact details but there were build / clippy errors / warnings
> without them.
>
> I am fine with updating code based on latest version of Rust and get
> these removed.
>
> Erik: Please build for 32 bit ARM too btw.

Will do. Will try to come up with some test suite that may be
upstreamable too.

>
> -- 
> viresh
>
> [1] https://lore.kernel.org/all/401d9417d895b8b1b19ca577c84347d89f7e0fbd.1667815011.git.viresh.kumar@xxxxxxxxxx/