Re: [libgpiod][PATCH] bindings: rust: fix clippy lint warnings

[Kent Gibson <warthog618@xxxxxxxxx>]

On Mon, Jun 19, 2023 at 10:13:52AM +0200, Erik Schilling wrote:
> On Mon Jun 19, 2023 at 9:57 AM CEST, Kent Gibson wrote:
> > On Mon, Jun 19, 2023 at 09:36:48AM +0200, Erik Schilling wrote:
> > > Sorry, got distracted while sorting out the MSRV mess that I sent a
> > > separate patch for [4].
> > > 
> >
> > My reasoning was simply that building the bindings as you suggested
> > resulted in lint warnings, which is noisy and iritating when trying to
> > lint my own code.
> 
> I fully agree that we should fix them! I was just confused about the
> explanation.
> 
> > But I'm just the messenger.  Your question would be better directed at
> > Viresh - it is his code so he should be able to tell you why the casts
> > are there.
> > IIRC we needed the casts historically, though I don't recall the rust
> > version we were using at the time.
> > If we've moved beyond that then I have no problem with the casts being
> > removed, in fact in my initial comment I lamented the fact they were
> > necessary.
> 
> ACK. Not sure how the situation was when the patches came together, but
> today I would suggest to just drop the casts. Do you want to respin your
> series or shall I send the fixes?
> 

You go ahead.

Cheers,
Kent.