Re: [PATCH] gpiolib: Fix irq_domain resource tracking for gpiochip_irqchip_add_domain()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 16, 2023 at 9:02 PM Michael Walle <michael@xxxxxxxx> wrote:
> Am 2023-06-16 16:13, schrieb Andy Shevchenko:
> > On Fri, Jun 16, 2023 at 09:30:06AM +0200, Michael Walle wrote:

...

> >>      /* Remove all IRQ mappings and delete the domain */
> >> -    if (gc->irq.domain) {
> >> +    if (!gc->irq.domain_is_ext && gc->irq.domain) {
> >
> > Looking at this, perhaps positive about allocation?
> >
> >       domain_is_allocated?
>
> I mean all domains are allocated ;)
>
> domain_is_allocated_externally? I'm bad with short and concise
> names..

Naming is one of the hardest problems in software...
Your variant is long, but conscious. I dunno. Bart, Linus, do you have
any ideas?

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux