Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 17 Jun 2023 10:08:10 +0100,
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> 
> On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> 
> > It seems there is no driver that requires custom IRQ chip
> > domain options. Drop the member and respective code.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> (...)
> > -               /* Some drivers provide custom irqdomain ops */
> >                 gc->irq.domain = irq_domain_create_simple(fwnode,
> >                         gc->ngpio,
> >                         gc->irq.first,
> > -                       gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > +                       &gpiochip_domain_ops,
> 
> We better run this by Marc Zyngier, and Thierry who introduced it.
> 
> But some grepping and looking seems to conclude you are righ!
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

No objection from my end. If this is unused, let's kill it.

Acked-by: Marc Zyngier <maz@xxxxxxxxxx>

	M.

-- 
Without deviation from the norm, progress is not possible.




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux