Re: [libgpiod][PATCH 0/2] bindings: cxx: fix potential glitch in gpiosetcxx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 12, 2023 at 04:56:51PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> Kent,
> 
> This is an alternative approach to the problem you raised with your gpioset
> patches. It adds a new helper method that allows to set all output values at
> request-time using the line_config's set_output_values() method.
> 
> Please take a look and let me know what you think.
> 

That works for me - it is waaaay less painful than the per-line approach.

Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>

for the series.

Though come to think of it, it could use tests as well.
But you can always add some subsequently.

Btw, this is also an example of the outcome I expected to see from
expanding the examples - identify common pain points and extend the API
to address them.

Cheers,
Kent.



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux