Re: [PATCH 1/1] dt-bindings: gpio: gpio-vf610: Add parsing of hogs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/06/2023 14:27, Alexander Stein wrote:
> Am Freitag, 9. Juni 2023, 14:15:53 CEST schrieb Krzysztof Kozlowski:
>> On 09/06/2023 14:10, Alexander Stein wrote:
>>> Allow parsing GPIO controller children nodes with GPIO hogs.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
>>> ---
>>> This implements the same as commit dfb49cc231a48 ("dt-bindings: gpio:
>>> fsl-imx-gpio: Add parsing of hogs") and reuses the commit message as
>>> well.
>>
>> But it was suboptimal. Do it like in commit 6c19974d1e83 ("dt-bindings:
>> gpio: Convert STMPE GPIO to YAML schema"), including also narrower pattern.
> 
> Ah, thanks. I wasn't aware it is part of generic dt-schema.
> Regarding the narrower pattern: dt-schema still uses the wider one. Is this 
> still correct or something which needs to be fixed?

dtschema must have wider pattern as it covers everything, all boards.

If existing DTS fits narrower pattern, make it narrower. It helps
keeping code consistent thus easier to read.

Best regards,
Krzysztof




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux