Simplify exit path of ->gpio_request_enable() hook and save a few bytes. add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10) Function old new delta chv_gpio_request_enable 296 286 -10 Total: Before=19199, After=19189, chg -0.05% Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx> --- drivers/pinctrl/intel/pinctrl-cherryview.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index 4942d22cf9d9..49af41e4b6af 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -799,6 +799,7 @@ static int chv_gpio_request_enable(struct pinctrl_dev *pctldev, { struct intel_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev); unsigned long flags; + int ret = 0; u32 value; raw_spin_lock_irqsave(&chv_lock, flags); @@ -806,9 +807,8 @@ static int chv_gpio_request_enable(struct pinctrl_dev *pctldev, if (chv_pad_locked(pctrl, offset)) { value = chv_readl(pctrl, offset, CHV_PADCTRL0); if (!(value & CHV_PADCTRL0_GPIOEN)) { - /* Locked so cannot enable */ - raw_spin_unlock_irqrestore(&chv_lock, flags); - return -EBUSY; + ret = -EBUSY; + goto out_unlock; } } else { struct intel_community_context *cctx = &pctrl->context.communities[0]; @@ -842,9 +842,10 @@ static int chv_gpio_request_enable(struct pinctrl_dev *pctldev, chv_writel(pctrl, offset, CHV_PADCTRL0, value); } +out_unlock: raw_spin_unlock_irqrestore(&chv_lock, flags); - return 0; + return ret; } static void chv_gpio_disable_free(struct pinctrl_dev *pctldev, -- 2.17.1