Re: [PATCH v3 2/5] gpio: gxp: Add HPE GXP GPIO

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Thu, Jun 8, 2023 at 5:58 PM Hawkins, Nick <nick.hawkins@xxxxxxx> wrote:
> > > Is there any documents available describing how regmap_gpio
> > > populates the GPIO lines? Does it automatically go through and add lines
> > > for each successful regmap_read and bits per byte?
>
> > Nope, it assumes one bit per register or something different if xlate
> > callback is defined. This is my understanding. That said, it might be
> > that this is a limitation which does not allow you to switch to that
> > library.
>
> Thank you for this feedback. After exploring the gpio_regmap it seems
> it does not fit my needs. Some of the GPIOs are a combination of
> several bits in a byte. For instance the Health LED or Identify LED have
> more than 2 states. If acceptable I believe the gxp-gpio-pl.c file should
> not use the gpio_regmap.

Yes, just mention this reasoning in the cover letter.

-- 
With Best Regards,
Andy Shevchenko