Re: [PATCH v1 1/2] pinctrl: moorefield: Fix open-drain pin mode configuration

[andy.shevchenko@xxxxxxxxx]

Tue, Jun 06, 2023 at 08:15:47AM +0300, Mika Westerberg kirjoitti:
> On Mon, Jun 05, 2023 at 06:45:22PM +0300, Andy Shevchenko wrote:
> > Currently the pin may not be configured as open-drain in some
> > cases because the argument may be 0 for the boolean types of
> > the pin configurations. Fix this by ignoring the argument.
> > 
> > With that, allow to actually restore pin to the push-pull mode.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Thank you!

> BTW, looking at the two drivers they seem to have a lot of
> commonalities. Perhaps it makes sense to consolidate?

Yes, that's the plan, perhaps for the next cycle.

-- 
With Best Regards,
Andy Shevchenko