RE: [v2][libgpiod][PATCH 1/1] gpio-tools-test.bats: modify delays in toggle test

["Slater, Joseph" <joe.slater@xxxxxxxxxxxxx>]

> -----Original Message-----
> From: andy.shevchenko@xxxxxxxxx <andy.shevchenko@xxxxxxxxx>
> Sent: Monday, June 5, 2023 1:04 PM
> To: Slater, Joseph <joe.slater@xxxxxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx; MacLeod, Randy
> <Randy.MacLeod@xxxxxxxxxxxxx>
> Subject: Re: [v2][libgpiod][PATCH 1/1] gpio-tools-test.bats: modify delays in
> toggle test
> 
> Mon, Jun 05, 2023 at 12:00:51PM -0700, joe.slater@xxxxxxxxxxxxx kirjoitti:
> > From: Joe Slater <joe.slater@xxxxxxxxxxxxx>
> >
> > The test "gpioset: toggle (continuous)" uses fixed delays to test
> > toggling values.  This is not reliable, so we switch to looking for
> > transitions from one value to another.
> >
> > We wait for a transition up to 1.5 seconds.
> 
> ...
> 
> > +gpiosim_wait_value() {
> > +	local OFFSET=$2
> > +	local EXPECTED=$3
> > +	local DEVNAME=${GPIOSIM_DEV_NAME[$1]}
> > +	local CHIPNAME=${GPIOSIM_CHIP_NAME[$1]}
> > +	local
> PORT=$GPIOSIM_SYSFS/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/value
> > +
> > +	for i in {1..15} ; do
> 
> Do you need space before semicolon?
> 
> > +		[ "$(<$PORT)" = "$EXPECTED" ] && return
> > +		sleep 0.1
> > +	done
> > +	return 1
> > +}
> 
> ...
> 
> > -			for LINE in $(find $BANKPATH/ | grep -E "line[0-9]+$")
> > +			for LINE in $(find $BANKPATH/ | egrep "line[0-9]+$")
> 
> Seems stray change.
[Slater, Joseph] 
The extra space is not necessary.  I removed it.  Putting egrep back was a mistake.  I'll send a V3 in a few minutes.

Joe
> 
> --
> With Best Regards,
> Andy Shevchenko
>