On Mon, Jun 5, 2023 at 4:53 AM Jiasheng Jiang <jiasheng@xxxxxxxxxxx> wrote: > > Add the missing check for platform_get_irq() and return error > if it fails. Here it seems better, but still needs an explanation why returning an error is not a problem (assuming DT might have a wrong number). I.o.w. you need to prove that with current code this fails in that case further. Otherwise you will need to prove that there may not be DT with a wrong number. -- With Best Regards, Andy Shevchenko