Fri, Jun 02, 2023 at 04:14:44PM +0200, Thierry Reding kirjoitti: > From: Prathamesh Shete <pshete@xxxxxxxxxx> > > This change adds support for the two pin controllers found on Tegra234. I'm not sure why my review got ignored. Did you receive it? https://lore.kernel.org/linux-gpio/ZHlGTgdsqcGOmVN2@surfacebook/ It seems most of the comments are actual even for this version. (Yes, you can ignore the struct pingroup usage as it's out of the scope of this change, obviously.) -- With Best Regards, Andy Shevchenko