On 01/06/2023 19:38, Nishanth Menon wrote: > For convenience (less code duplication), the pin controller pin > configuration register values were defined in the bindings header. > These are not some IDs or other abstraction layer but raw numbers used > in the registers. > > These constants do not fit the purpose of bindings. They do not > provide any abstraction, any hardware and driver independent ID. In > fact, the Linux pinctrl-single driver actually do not use the bindings > header at all. > > Commit f2de003e1426 ("dt-bindings: pinctrl: k3: Deprecate header with > register constants") already moved users to the local header, so, drop > the binding header. See background discussion in [1]. > This happened just a release ago, so I would rather expect to have it deprecated for some time, so out of tree DTBs won't be broken. But any platform ABI is up to platform maintainer so: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof