Thu, Jun 01, 2023 at 04:51:32PM +0800, Jiasheng Jiang kirjoitti: > Add the missing check for platform_get_irq and return error > if it fails. > girq->parents[0] = platform_get_irq(pdev, 0); > + if (girq->parents[0] < 0) > + return -ENODEV; Can you elaborate why error code has to be shadowed (overriden)? -- With Best Regards, Andy Shevchenko