Re: [PATCH v3 00/11] serial: sc16is7xx: fix GPIO regression and rs485 improvements

[Hugo Villeneuve <hugo@xxxxxxxxxxx>]

On Thu, 25 May 2023 13:27:52 +0300
andy.shevchenko@xxxxxxxxx wrote:

> Thu, May 25, 2023 at 12:03:13AM -0400, Hugo Villeneuve kirjoitti:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > 
> > Hello,
> > this patch series mainly fixes a GPIO regression and improve RS485 flags and properties
> > detection from DT.
> > 
> > It now also includes various small fixes and improvements that were previously
> > sent as separate patches, but that made testing everything difficult.
> 
> > Patches 1 and 2 are simple comments fix/improvements.
> 
> Usually we put fixes at the beginning of the series, but these patches are
> missing Fixed tag. Are they really fixes or can be simply moved to the end of
> the series?

Hi,
these are not code fixes, they are comments improvements. I was not aware that you need to put a Fixes tag for correcting syntax errors in comments, or adding comments to improve clarity.

I often submit such comments patches but was never asked to put a Fixes tag before. Seems strange to me...

Hugo.

> > Patch 3 fixes an issue when debugging IOcontrol register. After testing the GPIO
> > regression patches (patches 6 and 7, tests done by Lech Perczak), it appers that
> > this patch is also necessary for having the correct IOcontrol register values.
> > 
> > Patch 4 introduces a delay after a reset operation to respect datasheet
> > timing recommandations.
> > 
> > Patch 5 fixes an issue with init of first port during probing. This commit
> > brings some questions and I appreciate if people from the serial subsystem could
> > comment on my proposed solution.
> > 
> > Patch 6 fixes a bug with the output value when first setting the GPIO direction.
> > 
> > Patch 7, 8 and 9 fix a GPIO regression by (re)allowing to choose GPIO function for
> > GPIO pins shared with modem status lines.
> > 
> > Patch 10 allows to read common rs485 device-tree flags and properties.
> > 
> > Patch 11 add a custom dump function as relying on regmal debugfs is not really
> > practical for this driver.
> > 
> > I have tested the changes on a custom board with two SC16IS752 DUART using a
> > Variscite IMX8MN NANO SOM.
> 
> Other comments are per individual emails.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 
>