"pin_config_set" in pinconf_ops. In the function of registering pinctrl_dev, pinctrl_init_controller(), a non-null check has already been performed on the members pin_config_set and pin_config_group_set in the ops structure. Signed-off-by: Lizhe <sensor1010@xxxxxxx> --- drivers/pinctrl/pinconf.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c index d9d54065472e..7b078d4ab61e 100644 --- a/drivers/pinctrl/pinconf.c +++ b/drivers/pinctrl/pinconf.c @@ -158,10 +158,6 @@ int pinconf_apply_setting(const struct pinctrl_setting *setting) switch (setting->type) { case PIN_MAP_TYPE_CONFIGS_PIN: - if (!ops->pin_config_set) { - dev_err(pctldev->dev, "missing pin_config_set op\n"); - return -EINVAL; - } ret = ops->pin_config_set(pctldev, setting->data.configs.group_or_pin, setting->data.configs.configs, @@ -174,11 +170,6 @@ int pinconf_apply_setting(const struct pinctrl_setting *setting) } break; case PIN_MAP_TYPE_CONFIGS_GROUP: - if (!ops->pin_config_group_set) { - dev_err(pctldev->dev, - "missing pin_config_group_set op\n"); - return -EINVAL; - } ret = ops->pin_config_group_set(pctldev, setting->data.configs.group_or_pin, setting->data.configs.configs, -- 2.34.1