Re: [PATCH v2 1/1] gpio: mxc: use platform_get_irq_optional() to avoid an error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 9, 2023 at 7:00 PM Shenwei Wang <shenwei.wang@xxxxxxx> wrote:
>
> From: Fugang Duan <fugang.duan@xxxxxxx>
>
> Use platform_get_irq_optional() to avoid an error message for the
> optional irq.

Looking into the code more, this won't happen as the first operation
is to check how many IRQs the device already has. So, you may go
further and kill that irq_count variable completely with your
suggestion.

> Restructuring the codes to ask for the first mandatory IRQ before
> the optional one.
>
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")

Hmm...
With the above, the proposed change does not fix anything, I believe.
And I'm not sure that this commit is what we want to actually fix.

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux