Re: [RFC PATCH net-next v5 1/9] net: txgbe: Add software nodes to support phylink

[Simon Horman <simon.horman@xxxxxxxxxxxx>]

On Wed, Apr 26, 2023 at 03:14:26PM +0800, Jiawen Wu wrote:

...

> @@ -663,10 +665,21 @@ static int txgbe_probe(struct pci_dev *pdev,
>  			 "0x%08x", etrack_id);
>  	}
>  
> -	err = register_netdev(netdev);
> +	txgbe = devm_kzalloc(&pdev->dev, sizeof(*txgbe), GFP_KERNEL);
> +	if (!txgbe)

Hi Jiawen,

I think yo need to set err here.

> +		goto err_release_hw;
> +

...