Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/26/2023 10:12 PM, Andy Shevchenko wrote:
On Wed, Apr 26, 2023 at 6:18 PM Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx> wrote:
On 4/26/2023 8:34 PM, andy.shevchenko@xxxxxxxxx wrote:
Mon, Apr 24, 2023 at 02:33:50PM +0530, Rohit Agarwal kirjoitti:
...

+#define FUNCTION(fname)                                                     \
+    [msm_mux_##fname] = {                                           \
+            .name = #fname,                                         \
+            .groups = fname##_groups,                               \
+    .ngroups = ARRAY_SIZE(fname##_groups),                          \
+    }
PINCTRL_PINFUNCTION() ?
Ok, Will update this. Shall I also update "PINGROUP" to "PINCTRL_PINGROUP"?
Yes, please.
PINCTRL_PINGROUP cannot be used as it is, since msm_pigroup has multiple other fields that needs to be set
for each pingroup defined.
Would rename this to SDX75_PINGROUP, as seen on some other platforms.
Would that be ok?

Thanks,
Rohit.




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux