On 4/26/2023 10:42 PM, andy.shevchenko@xxxxxxxxx wrote:
Sun, Apr 23, 2023 at 09:59:43PM +0800, Yan Wang kirjoitti:
if hardware number different to array index,it needs to clear to points
memory space if the array_info have been assigned a value.
Can you explain a bit more what's going on there?
...
Hi Andy,
I use gpiod_get_array() to get a gpio array form the node of DTS.
the node is as follows:
...
gpios = <&gpio1 0 0>, <&gpio1 10 0>;
...
first scan 0 pin of gpio1, its index and hardware number are 0,
the (descs->ndescs == 0 && gpio_chip_hwgpio(desc) == 0) is true and
descs->info = array_info. then scan 10 pin , its index is 1 ,but
hardware number is 10 , the (gpio_chip_hwgpio(desc) != descs->ndescs)
is true. array_info = NULL, Just make array_info point to NULL, Did't
clean descs->info memory or point it to NULL. Should the array_info
point to memory be cleared ? if not cleared ,I use
gpiod_set_array_value_cansleep() setting pin 10 of gpio1 is invalid. I
found that the set_mask and get_mask vlaues of descs->info are seted
0x03 in gpiod_get_array(), I think 0x401 is their correct value. Thank
you review
if (bitmap_full(array_info->get_mask, descs->ndescs)) {
+ /*clear descs->info*/
+ memset(array_info, 0, sizeof(struct gpio_array));
array_info = NULL;
...
}
