Hi Esteban, thanks for your patch! On Fri, Apr 14, 2023 at 12:12 PM Esteban Blanc <eblanc@xxxxxxxxxxxx> wrote: > TI TPS6594 PMIC has 11 GPIOs which can be used for different > functions. > > This add a pinctrl and pinmux drivers in order to use those functions. > > Signed-off-by: Esteban Blanc <eblanc@xxxxxxxxxxxx> (...) > +config PINCTRL_TPS6594 > + tristate "Pinctrl and GPIO driver for TI TPS6594 PMIC" > + depends on MFD_TPS6594 > + default MFD_TPS6594 > + select PINMUX > + select GPIOLIB select GPIO_REGMAP ? I think this driver can use the GPIO_REGMAP helper library. Please look into other drivers using this, such as drivers/gpio/gpio-sl28cpld.c Yours, Linus Walleij