On 3/28/2023 6:59 PM, Linus Walleij wrote:
On Thu, Mar 23, 2023 at 1:29 PM Dhruva Gole <d-gole@xxxxxx> wrote:The interrupt enable bits might be set if we want to use the GPIO as wakeup source. Clearing this will mean disabling of interrupts in the GPIO banks that we may want to wakeup from. Thus remove the line that was clearing this bit from the driver's save context function. Fixes: 0651a730924b ("gpio: davinci: Add support for system suspend/resume PM") Cc: Devarsh Thakkar <devarsht@xxxxxx> Signed-off-by: Dhruva Gole <d-gole@xxxxxx>Looks like the right solution to me. I'm a bit surprised given how long we have had this driver. I suppose people have used out-of-tree patches for suspend/resume. :( Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Acked-by: Keerthy <j-keerthy@xxxxxx>
Yours, Linus Walleij
