On Mon, Mar 20, 2023 at 6:39 PM Chester Lin <clin@xxxxxxxx> wrote: > > Instead of relying on of_match_device(), using of_device_get_match_data() > can simplify implementation and avoid code duplication. Suggested-by? > Signed-off-by: Chester Lin <clin@xxxxxxxx> ... > + soc_info = (struct s32_pinctrl_soc_info *) > + of_device_get_match_data(&pdev->dev); Drop the ugly casting, it's not needed. -- With Best Regards, Andy Shevchenko