On Mon, Mar 20, 2023 at 5:07 AM Bjorn Andersson <andersson@xxxxxxxxxx> wrote: > > Fine by me, but I want you to first consider switching the > > custom register accessors to regmap. (...) > IMHO this is quite a significant effort, and given that the driver seems > to be doing its job I'd rather see such efforts being focused elsewhere. I think you know it better than me, if regmap is just going to clutter the view the don't do it. Regmap does have the upside of looking the same on all platforms so it would potentially give less maintenance burden. Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> for these patches if you need to merge them elsewhere, I can also queue them if you ACK them. Yours, Linus Walleij