Re: [libgpiod][PATCH] tools: gpiomon: fix setting event clock type

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Mar 15, 2023 at 09:34:56AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> Fix an inverted logic bug when parsing event clock type in gpiomon.

Oh, oh. Good catch and fix!

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Fixes: 8ffb6489286f ("tools: line name focussed rework")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> Reported-by: Wes Tarro <wes.tarro@xxxxxxxxxxxxxxx>
> ---
>  tools/gpiomon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/gpiomon.c b/tools/gpiomon.c
> index ec177df..c2684c2 100644
> --- a/tools/gpiomon.c
> +++ b/tools/gpiomon.c
> @@ -99,7 +99,7 @@ static int parse_event_clock_or_die(const char *option)
>  {
>  	if (strcmp(option, "realtime") == 0)
>  		return GPIOD_LINE_CLOCK_REALTIME;
> -	if (strcmp(option, "hte") != 0)
> +	if (strcmp(option, "hte") == 0)
>  		return GPIOD_LINE_CLOCK_HTE;
>  	if (strcmp(option, "monotonic") != 0)
>  		die("invalid event clock: %s", option);
> -- 
> 2.37.2
> 

-- 
With Best Regards,
Andy Shevchenko