Re: [libgpiod][PATCH] tools: gpiomon: fix setting event clock type

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Mar 15, 2023 at 9:35 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Fix an inverted logic bug when parsing event clock type in gpiomon.
>
> Fixes: 8ffb6489286f ("tools: line name focussed rework")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> Reported-by: Wes Tarro <wes.tarro@xxxxxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> -       if (strcmp(option, "hte") != 0)
> +       if (strcmp(option, "hte") == 0)

I tend to code if (!strcmp(option, "hte")) but taste differs.

Yours,
Linus Walleij