Re: [libgpiod,v4 0/2] tools: fix compile issues when GNU extensions are not present

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 6, 2023 at 7:46 PM Benjamin Li <benl@xxxxxxxxxxxx> wrote:
>
> v4:
> - Keep semantics consistent with before: help messages should return the full
>   name, not the short name. (Bart)
>
> v3:
> - Collapse --version print into a single line. (Andy)
> - Handle program name fully independently rather than rely on any extensions
>   at all. (Bart)
> - Move Android.bp into contrib/ folder. (Bart)
> - Add SPDX license tag and clean up Android.bp patch comments in the context
>   of it possibly being accepted into the upstream tree.
>
> v2:
> - Add missing Signed-off-by: tags.
>
> v1:
> Fix issue when building against a C library without GNU extensions, such
> as Android's Bionic libc.
>
> A commit with a sample Android.bp file that's working against Android 11 is
> included for informational purposes, which I don't expect Bartosz to pull.
>
> Benjamin Li (2):
>   tools: remove dependency on glibc program_invocation_[short_]name
>   contrib: add sample Android.bp to build within an Android tree
>
>  contrib/Android.bp   | 136 +++++++++++++++++++++++++++++++++++++++++++
>  tools/gpiodetect.c   |   5 +-
>  tools/gpioget.c      |   5 +-
>  tools/gpioinfo.c     |   5 +-
>  tools/gpiomon.c      |   5 +-
>  tools/gpionotify.c   |   5 +-
>  tools/gpioset.c      |   5 +-
>  tools/tools-common.c |  34 ++++++++---
>  tools/tools-common.h |   4 +-
>  9 files changed, 183 insertions(+), 21 deletions(-)
>  create mode 100644 contrib/Android.bp
>
> --
> 2.25.1
>

Thanks, I applied both patches. For the second one: I extended it so
that the android build file ends up in release tarballs generated by
'make dist'.

Bartosz




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux