Re: [PATCH] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h>

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Andy,

On Thu, Mar 9, 2023 at 3:10 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> On Thu, Mar 09, 2023 at 02:52:55PM +0100, Geert Uytterhoeven wrote:
> > shx3_defconfig:
> >
> >     arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’:
> >     arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’
> >       246 |                 baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i;
> >         |                                                              ^
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@xxxxxxxxxxxxxx
> > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Thank you!
>
> ...
>
> >  #include <linux/gpio.h>
> > +#include <linux/gpio/driver.h>
>
> Do we still need the legacy header?

Apparently not.  And "make arch/sh/boards/mach-x3proto/setup.i"
confirms it's not included indirectly.

Will send a v2...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds