Hi Andrew, Thank you for the patch! Yet something to improve: [auto build test ERROR on brgl/gpio/for-next] [also build test ERROR on linus/master v6.3-rc1 next-20230309] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andrew-Davis/gpio-twl4030-Use-devm_gpiochip_add_data-to-simplify-remove-path/20230308-034717 base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next patch link: https://lore.kernel.org/r/20230307193346.8718-3-afd%40ti.com patch subject: [PATCH v2 3/6] gpio: sch311x: Use devm_gpiochip_add_data() to simplify remove path config: x86_64-randconfig-a001 (https://download.01.org/0day-ci/archive/20230309/202303091640.6XjHNouG-lkp@xxxxxxxxx/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/fcfc10c6817ac3ea88ced58cce2ae8568b0f2030 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andrew-Davis/gpio-twl4030-Use-devm_gpiochip_add_data-to-simplify-remove-path/20230308-034717 git checkout fcfc10c6817ac3ea88ced58cce2ae8568b0f2030 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpio/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303091640.6XjHNouG-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/gpio/gpio-sch311x.c:322:13: error: use of undeclared identifier 'sch311x_gpio_remove' .remove = sch311x_gpio_remove, ^ 1 error generated. vim +/sch311x_gpio_remove +322 drivers/gpio/gpio-sch311x.c 12262bef8f4614 Bruno Randolf 2013-12-04 318 12262bef8f4614 Bruno Randolf 2013-12-04 319 static struct platform_driver sch311x_gpio_driver = { 12262bef8f4614 Bruno Randolf 2013-12-04 320 .driver.name = DRV_NAME, 12262bef8f4614 Bruno Randolf 2013-12-04 321 .probe = sch311x_gpio_probe, 12262bef8f4614 Bruno Randolf 2013-12-04 @322 .remove = sch311x_gpio_remove, 12262bef8f4614 Bruno Randolf 2013-12-04 323 }; 12262bef8f4614 Bruno Randolf 2013-12-04 324 12262bef8f4614 Bruno Randolf 2013-12-04 325 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests