Re: [PATCH v1] drivers/gpio: remove redundant platform_set_drvdata()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 6, 2023 at 11:54 PM <andy.shevchenko@xxxxxxxxx> wrote:
>
> Mon, Mar 06, 2023 at 11:15:32PM +0800, Lizhe kirjoitti:
> > remove redundant platform_set_drvdata(),
> > Because there is no place to use the platform_get_drvdata
>
> The commit message has to be improved:
> - English grammar and punctuation
> - style of func()
> - clearer wording on what it all means
>
> Note, to get driver data the dev_get_drvdata() can be used. Do you aware about
> this? And hHow did you check these drivers?
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

I would also add to that: you need to use your full first and family
name in SoB because I assume you don't just go by "Lizhe".

Bartosz




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux