On Tue, Mar 07, 2023 at 10:54:30AM -0600, Andrew Davis wrote: > Use devm version of gpiochip add function to handle removal for us. > > While here update copyright and module author. ... > - mutex_destroy(&gpio->lock); You need to wrap this into devm. -- With Best Regards, Andy Shevchenko
Re: [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path
- From: Andy Shevchenko <andy@xxxxxxxxxx>
- Date: Tue, 7 Mar 2023 19:44:04 +0200
- In-reply-to: <20230307165432.25484-4-afd@ti.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20230307165432.25484-1-afd@ti.com> <20230307165432.25484-4-afd@ti.com>
- Follow-Ups:
- References:
- [PATCH 1/6] gpio: ich: Use devm_gpiochip_add_data() to simplify remove path
- From: Andrew Davis
- [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path
- From: Andrew Davis
- [PATCH 1/6] gpio: ich: Use devm_gpiochip_add_data() to simplify remove path
- Prev by Date: Re: [PATCH 1/6] gpio: ich: Use devm_gpiochip_add_data() to simplify remove path
- Next by Date: Re: [PATCH 2/6] gpio: twl4030: Use devm_gpiochip_add_data() to simplify remove path
- Previous by thread: [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path
- Next by thread: Re: [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path
- Index(es):
 |