Re: [PATCH 2/4] gpio: loongson1: Introduce ls1x_gpio_chip struct

[Kelvin Cheung <keguang.zhang@xxxxxxxxx>]

On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@xxxxxxxxx> wrote:
>
> Wed, Feb 22, 2023 at 07:12:11PM +0800, Keguang Zhang kirjoitti:
> > Introduce and allocate ls1x_gpio_chip struct containing
> > gpio_chip and reg_base to avoid global gpio_reg_base.
> >
> > Use readl() & writel() instead of __raw_readl() & __raw_writel().
>
> Please, split this to two pathes.
>
Sure.
Thanks!

> --
> With Best Regards,
> Andy Shevchenko
>
>


-- 
Best regards,

Kelvin Cheung