On Tue, Feb 28, 2023 at 09:44:02PM +0100, Michael Walle wrote: > Hi, > > Am 2023-02-28 02:53, schrieb William Breathitt Gray: > > A struct gpio_regmap is passed as a parameter for reg_mask_xlate(), but > > for callbacks to access its members the declaration must be exposed. > > That parameter is only an opaque one to call any gpio_regmap_*(). > > > Move the struct gpio_regmap declaration from drivers/gpio/gpio-regmap.c > > to include/linux/gpio/regmap.h so callbacks can properly interact with > > struct gpio_regmap members. > > That struct should be kept private. It seems you only need the > regmap. Either introduce a gpio_regmap_get_regmap() or add the > regmap to a private struct and use gpio_regmap_get_drvdata(). > > -michael Ah, I'll drop this patch then and use gpio_regmap_get_drvdata() in v2 instead to get access to the regmap. William Breathitt Gray
Attachment:
signature.asc
Description: PGP signature
