> +config PINCTRL_MLXBF > + tristate "NVIDIA BlueField-3 SoC Pinctrl driver" > + depends on (MELLANOX_PLATFORM && ARM64 && ACPI) This is wrong. Please make sure you cover more testing. Also, do you really need an ACPI dependency? Could you please provide more details on why this is wrong? All our upstreamed drivers use the same "depends on" Our pinctrl driver only applies to Mellanox platforms, ARM64 and use ACPI tables.
RE: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: RE: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
- From: Asmaa Mnebhi <asmaa@xxxxxxxxxx>
- Date: Thu, 16 Feb 2023 17:50:56 +0000
- Accept-language: en-US
- In-reply-to: <Y+eCNEHcmo4qapcI@smile.fi.intel.com>
- References: <cover.1676042188.git.asmaa@nvidia.com> <acd85e20d3e8d45ce3254e6ffe5ad2b5039b1a34.1676042188.git.asmaa@nvidia.com> <Y+eCNEHcmo4qapcI@smile.fi.intel.com>
- Follow-Ups:
- Re: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
- From: Andy Shevchenko
- Re: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
- References:
- [PATCH v3 0/2] Add NVIDIA BlueField-3 GPIO driver and pin controller
- From: Asmaa Mnebhi
- [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
- From: Asmaa Mnebhi
- Re: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
- From: Andy Shevchenko
- [PATCH v3 0/2] Add NVIDIA BlueField-3 GPIO driver and pin controller
- Prev by Date: Re: [PATCH v2 2/2] pinctrl: add mt7981 pinctrl driver
- Next by Date: Re: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
- Previous by thread: Re: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
- Next by thread: Re: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
- Index(es):
 |