RE: [EXT] Re: [PATCH 1/1] gpio: mxc: remove static allocation of GPIO base

[Shenwei Wang <shenwei.wang@xxxxxxx>]

> -----Original Message-----
> From: Bartosz Golaszewski <brgl@xxxxxxxx>
> Sent: Wednesday, February 15, 2023 2:30 AM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH 1/1] gpio: mxc: remove static allocation of GPIO base
> 
> Caution: EXT Email
> 
> On Tue, Feb 14, 2023 at 11:47 PM Shenwei Wang <shenwei.wang@xxxxxxx>
> wrote:
> >
> > The latest gpio driver framework will give the following warning when
> > it detects the static allocation of the GPIO bases.
> >
> > "[    1.329312] gpio gpiochip0: Static allocation of GPIO base is
> > deprecated, use dynamic allocation."
> >
> > This patch removes the static allocation of GPIO base to get rid of
> > the warning message.
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang@xxxxxxx>
> > ---
> >  drivers/gpio/gpio-mxc.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c index
> > d5626c572d24..07948175441c 100644
> > --- a/drivers/gpio/gpio-mxc.c
> > +++ b/drivers/gpio/gpio-mxc.c
> > @@ -450,8 +450,6 @@ static int mxc_gpio_probe(struct platform_device
> *pdev)
> >         port->gc.request = gpiochip_generic_request;
> >         port->gc.free = gpiochip_generic_free;
> >         port->gc.to_irq = mxc_gpio_to_irq;
> > -       port->gc.base = (pdev->id < 0) ? of_alias_get_id(np, "gpio") * 32 :
> > -                                            pdev->id * 32;
> >
> >         err = devm_gpiochip_add_data(&pdev->dev, &port->gc, port);
> >         if (err)
> > --
> > 2.34.1
> >
> 
> This is one of the drivers for which we can't do it yet:

I would suggest to remove the alias logic inside the gpio driver. The alias feature should be 
managed outside of the gpio driver and work as a separate driver to handle the alias
in one place.

Thanks,
Shenwei

> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kern
> el.org%2Flinux-
> gpio%2F20230120104647.nwki4silrtd7bt3w%40pengutronix.de%2F&data=05%7
> C01%7Cshenwei.wang%40nxp.com%7C9a55c18e62dd414f6f5f08db0f2ecea4%7
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638120465926987476%7
> CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=KxOAhOJ4fm1tNNc
> RLJtx4G02alhWnswQdv%2BIfkojBYU%3D&reserved=0
> 
> Bart