On Wed, Feb 15, 2023 at 12:18 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Tue, Feb 14, 2023 at 11:52 AM <andy.shevchenko@xxxxxxxxx> wrote: > > Tue, Feb 14, 2023 at 08:36:38AM +0100, Alexander Stein kirjoitti: > > > Since recently, the kernel is nagging about mutable irq_chips: > > > > > > "not an immutable chip, please consider fixing it!" > > > > > > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new > > > helper functions and call the appropriate gpiolib functions. > > > > ... > > > > > The overall changes are based on commit f1138dacb7ff > > > ("gpio: sch: make irq_chip immutable") > > > > Nice, but you forgot one crucial detail. You need to mark GPIO resuested > > whenever it's locked as IRQ and otherwise when unlocked. > > +static const struct irq_chip vf610_irqchip = { > (...) > + GPIOCHIP_IRQ_RESOURCE_HELPERS, > > That's what this macro does ;) Maybe I was unclear, but I meant that the above mentioned macro requires to have the helpers to be called to enable the GPIO line. -- With Best Regards, Andy Shevchenko