On Thu, Feb 2, 2023 at 4:12 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > Now as I'm thinking more of your nice job, it may be less effort to everybody > if you start from moving the driver to be a real pin control driver united with > GPIO handling. Agreed, the more complex these expanders get the closer they move to becoming pin controllers with GPIO. drivers/pinctrl/pinctrl-sx150x.c drivers/pinctrl/pinctrl-mcp23s08.c drivers/pinctrl/pinctrl-stmfx.c Come to mind especially. So if it makes more sense - go for it! Yours, Linus Walleij