Re: [PATCH v2 04/11] gpiolib: Clear the gpio_device's fwnode initialized flag before adding

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, Jan 30, 2023 at 02:31:53PM +0000, Sudeep Holla wrote:
> On Thu, Jan 26, 2023 at 04:11:31PM -0800, Saravana Kannan wrote:
> > Registering an irqdomain sets the flag for the fwnode. But having the
> > flag set when a device is added is interpreted by fw_devlink to mean the
> > device has already been initialized and will never probe. This prevents
> > fw_devlink from creating device links with the gpio_device as a
> > supplier. So, clear the flag before adding the device.

...

> > +	/*
> > +	 * If fwnode doesn't belong to another device, it's safe to clear its
> > +	 * initialized flag.
> > +	 */
> > +	if (!gdev->dev.fwnode->dev)
> > +		fwnode_dev_initialized(gdev->dev.fwnode, false);
> 
> This is the one causing the kernel crash during the boot on FVP which
> Naresh has reported. Just reverted this and was able to boot, confirming
> the issue with this patch.

I'm wondering if

	if (!dev_fwnode(&gdev->dev)->dev)
		fwnode_dev_initialized(&dev_fwnode(gdev->dev), false);

works.

-- 
With Best Regards,
Andy Shevchenko