Re: [PATCH 6/8] gpiolib: split linux/gpio/driver.h out of linux/gpio.h

["Arnd Bergmann" <arnd@xxxxxxxx>]

On Thu, Jan 26, 2023, at 15:04, Andy Shevchenko wrote:
> On Thu, Jan 26, 2023 at 02:27:59PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> 
>> Almost all gpio drivers include linux/gpio/driver.h, and other
>> files should not rely on includes from this header.
>> 
>> Remove the indirect include from here and include the correct
>> headers directly from where they are used.
>
> Some minor nit-picks below, otherwise
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
>> +#include <linux/of.h>
>
> Taking the limited context into account, I think this makes more sense to be
> placed before platform_device.h as to keep longer _sorted_ chain.
>
>>  #include <linux/gpio/gpio-reg.h>
>>  #include <linux/gpio/machine.h>
>> +#include <linux/gpio/driver.h>
>
> Similar. Keep it more sorted.
>

>> +#include <linux/gpio/driver.h>
>>  #include <linux/gpio.h>
>
> Here is the opposite ordering to the above similar cases. Swap?

Changed all as suggested, thanks!

     Arnd