Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT

[Nikita Shubin <nikita.shubin@xxxxxxxxxxx>]

Hello Arnd!

On Tue, 17 Jan 2023 11:15:20 +0100
"Arnd Bergmann" <arnd@xxxxxxxx> wrote:

> On Tue, Jan 17, 2023, at 11:08, Nikita Shubin wrote:
> 
> > 
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id ep93xx_gpio_match[] = {
> > +	{ .compatible = "cirrus,ep93xx-gpio" },
> > +	{ /* end of table */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, ep93xx_gpio_match);
> > +#endif
> > +
> >  static struct platform_driver ep93xx_gpio_driver = {
> >  	.driver		= {
> >  		.name	= "gpio-ep93xx",
> > +		.of_match_table = ep93xx_gpio_match,
> >  	},
> >  	.probe		= ep93xx_gpio_probe,  
> 
> The #ifdef here is wrong and will cause a build failure because
> of the unconditional reference to the variable.
> 
> Just remove the #ifdef/#endif.

Sorry about that - i remember that i should drop it everywhere, which
did for all but ep93xx-gpio, i am dropping match currently, as it will
produce a warning without dt-bindings documentation, it will be
introduced together with the rest of series.

> 
>     Arnd