On Fri, 20 Jan 2023, at 09:48, Joel Stanley wrote:
> The function signature is int, but we return a bool. Instead return a
> negative errno as the kerneldoc suggests.
>
> Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs")
> Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
:facepalm:
Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx>
Re: [PATCH] pinctrl: aspeed: Fix confusing types in return value
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] pinctrl: aspeed: Fix confusing types in return value
- From: "Andrew Jeffery" <andrew@xxxxxxxx>
- Date: Fri, 20 Jan 2023 12:54:24 +1030
- Feedback-id: idfb84289:Fastmail
- In-reply-to: <20230119231856.52014-1-joel@jms.id.au>
- References: <20230119231856.52014-1-joel@jms.id.au>
- User-agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0
- References:
- [PATCH] pinctrl: aspeed: Fix confusing types in return value
- From: Joel Stanley
- [PATCH] pinctrl: aspeed: Fix confusing types in return value
- Prev by Date: [PATCH] dt-bindings: pinctrl: qcom,pmic-mpp: Restrict 'mpp' child node name pattern
- Next by Date: Re: [PATCH] pinctrl: aspeed-g5: Bypass clock check when fetching regmap
- Previous by thread: [PATCH] pinctrl: aspeed: Fix confusing types in return value
- Next by thread: Re: [PATCH] pinctrl: aspeed: Fix confusing types in return value
- Index(es):
 |