Re: [PATCH] gpiolib: fix linker errors when GPIOLIB is disabled

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Tue, Jan 17, 2023 at 11:17 AM Pierluigi Passaro
<pierluigi.p@xxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 17, 2023 at 10:36 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > On Mon, Jan 16, 2023 at 3:08 PM Pierluigi Passaro
> > <pierluigi.p@xxxxxxxxxxxxx> wrote:
> > >
> > > Both the functions gpiochip_request_own_desc and
> > > gpiochip_free_own_desc are exported from
> > >     drivers/gpio/gpiolib.c
> > > but this file is compiled only when CONFIG_GPIOLIB is enabled.
> > > Move the protototypes under "#ifdef CONFIG_GPIOLIB" and provide
> > > reasonable definitions in the "#else" branch.
> > >
> > > Signed-off-by: Pierluigi Passaro <pierluigi.p@xxxxxxxxxxxxx>
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > Please add a Fixes tag.
> >
> I beg your pardon for the question: how can I "add a Fixes tag" ?
> Can you point me to any reference documentation / instructions ?
> Thanks
> >

Look at the output of `git blame` on the file in question and see who
added the changes that introduced the problem. Then, before your
Sign-off in the git message add: Fixes: <12 chars of the commit hash>
("<commit subject>"). See Existing commits with fixes for reference.

Bart