On Mon, Jan 16, 2023 at 10:03:47AM +0100, Bartosz Golaszewski wrote: > On Fri, Jan 13, 2023 at 7:25 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: ... > > +#include <linux/mod_devicetable.h> > > #include <linux/module.h> > > -#include <linux/gpio/driver.h> > > +#include <linux/platform_device.h> > > #include <linux/regmap.h> > > #include <linux/slab.h> > > -#include <linux/of_device.h> > > + > > +#include <linux/gpio/driver.h> > > Any reason for having it separately here? Yes. The idea is to emphasize the relationship between the driver and the subsystem it's written for. P.S. Thanks for applying the rest of my contribution. -- With Best Regards, Andy Shevchenko