Re: [libgpiod][PATCH 14/16] bindings: rust: make request_config optional in Chip.request_lines()

[Viresh Kumar <viresh.kumar@xxxxxxxxxx>]

On 13-01-23, 22:52, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> Request config is not necessary to request lines. In C API we accept
> a NULL pointer, in C++ it's not necessary to assign a request_config
> to the request builder, in Python the consumer and event buffer size
> arguments are optional. Let's make rust bindings consistent and not
> require the request config to be always present. Convert the argument
> in request_lines to Option and update the rest of the code.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
>  bindings/rust/libgpiod/examples/gpio_events.rs         |  2 +-
>  .../libgpiod/examples/gpio_threaded_info_events.rs     |  2 +-
>  bindings/rust/libgpiod/examples/gpioget.rs             |  2 +-
>  bindings/rust/libgpiod/examples/gpiomon.rs             |  2 +-
>  bindings/rust/libgpiod/examples/gpioset.rs             |  2 +-
>  bindings/rust/libgpiod/src/chip.rs                     | 10 ++++++++--
>  bindings/rust/libgpiod/tests/common/config.rs          |  2 +-
>  bindings/rust/libgpiod/tests/info_event.rs             |  2 +-
>  8 files changed, 15 insertions(+), 9 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

-- 
viresh