On 10/01/2023 13:13, devi priya wrote: > From: POOVENDHAN SELVARAJ <quic_poovendh@xxxxxxxxxxx> > > Add initial device tree support for Qualcomm IPQ9574 SoC > and AL02 board > > Co-developed-by: Anusha Rao <quic_anusha@xxxxxxxxxxx> > Signed-off-by: Anusha Rao <quic_anusha@xxxxxxxxxxx> > Co-developed-by: devi priya <quic_devipriy@xxxxxxxxxxx> > Signed-off-by: devi priya <quic_devipriy@xxxxxxxxxxx> > Signed-off-by: POOVENDHAN SELVARAJ <quic_poovendh@xxxxxxxxxxx> Don't use CAPITAL CASE FOR NAMES BUT Camel Case. Although different languages might have different rules, but most cases when transliterated to English (or Latin alphabet), the name Start with capital letter. The same in your case. > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts | 69 ++++ One more: Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Best regards, Krzysztof