Re: [PATCH 06/18] dt-bindings: interconnect: qcom: document the interconnects for sa8775p

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 09/01/2023 18:44, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> Add a set of new compatibles and DT include defines for the sa8775p
> platforms.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
>  .../bindings/interconnect/qcom,rpmh.yaml      |  14 ++
>  .../dt-bindings/interconnect/qcom,sa8775p.h   | 231 ++++++++++++++++++
>  2 files changed, 245 insertions(+)
>  create mode 100644 include/dt-bindings/interconnect/qcom,sa8775p.h
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> index a429a1ed1006..ad3e0c7e9430 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> @@ -27,6 +27,20 @@ properties:
>  
>    compatible:
>      enum:
> +      - qcom,sa8775p-aggre1-noc
> +      - qcom,sa8775p-aggre2-noc
> +      - qcom,sa8775p-clk-virt

Are you sure they come with IO address space? IOW, was the binding and
DTS tested against each other?

All recent bindings are split into their own file:

https://lore.kernel.org/all/20221223132040.80858-3-krzysztof.kozlowski@xxxxxxxxxx/

https://lore.kernel.org/all/20221202232054.2666830-2-abel.vesa@xxxxxxxxxx/


> +      - qcom,sa8775p-config-noc
> +      - qcom,sa8775p-dc-noc
> +      - qcom,sa8775p-gem-noc
> +      - qcom,sa8775p-gpdsp-anoc
> +      - qcom,sa8775p-lpass-ag-noc
> +      - qcom,sa8775p-mc-virt
> +      - qcom,sa8775p-mmss-noc
> +      - qcom,sa8775p-nspa-noc
> +      - qcom,sa8775p-nspb-noc
> +      - qcom,sa8775p-pcie-anoc
> +      - qcom,sa8775p-system-noc
>        - qcom,sc7180-aggre1-noc
>        - qcom,sc7180-aggre2-noc
>        - qcom,sc7180-camnoc-virt
> diff --git a/include/dt-bindings/interconnect/qcom,sa8775p.h b/include/dt-bindings/interconnect/qcom,sa8775p.h
> new file mode 100644
> index 000000000000..8d5968854187
> --- /dev/null
> +++ b/include/dt-bindings/interconnect/qcom,sa8775p.h

Filename matching family/compatible style, so just like sm8550.

> @@ -0,0 +1,231 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */

Dual license.

Best regards,
Krzysztof