Re: [PATCH] gpio: pcf857x: Implement get_multiple/set_multiple methods

[Radu Rendec <radu.rendec@xxxxxxxxx>]

On Fri, 2023-01-06 at 15:17 +0100, Bartosz Golaszewski wrote:
> On Wed, Jan 4, 2023 at 2:20 AM Radu Rendec <radu.rendec@xxxxxxxxx> wrote:
> > 
> > +static int pcf857x_get_multiple(struct gpio_chip *chip, unsigned long *mask,
> > +                               unsigned long *bits)
> > +{
> > +       struct pcf857x  *gpio = gpiochip_get_data(chip);
> > +       int             value = gpio->read(gpio->client);
> 
> Ugh, this whitespacing is awful but I get it that you only tried to
> stay consistent with the rest of the code. Could you add a patch
> before this one that removes those tabs from local variables? IMO This
> makes the code less readable, not more. While at it: you can also
> change all instances of 'unsigned' to 'unsigned int' as per the
> checkpatch rule.
> 
> Otherwise it looks good!

Thanks for reviewing the patch. Happy to remove those weird tabs. I'm
not a fan either, and as you guessed I just tried to stay consistent.
It's not just the local variables though, it's also the definition of
struct pcf857x and some initialization in pcf857x_probe(). 

I will send a v2 patch series shortly. If you think it's better to fix
the other tabs as well, please just let me know. Thanks!

Radu