Re: [PATCH v5 0/9] Add RZ/G2L POEG support

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Dec 15, 2022 at 10:32 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:

> This patch series add support for controlling output disable function using sysfs.

What's wrong with using the debugfs approach Drew implemented in
commit 6199f6becc869d30ca9394ca0f7a484bf9d598eb
"pinctrl: pinmux: Add pinmux-select debugfs file"
?

Something driver specific seems like a bit of a hack, does it not?

If this should go into sysfs we should probably create something
generic, such as a list of stuff to be exported as sysfs switches.

It generally also looks really dangerous, which is another reason
for keeping it in debugfs. It's the big hammer to hurt yourself with,
more or less.

Yours,
Linus Walleij